Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger: remove unused COMMONAPI_EXPORT #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barbieri
Copy link

@barbieri barbieri commented May 8, 2021

The structure is declared in the header and the export is unused as seen
with clang and -Wignored-attributes:

CommonAPI-3.2/CommonAPI/Logger.hpp:31:37: warning: 'visibility' attribute ignored when parsing type [-Wignored-attributes]
    enum class Level : std::uint8_t COMMONAPI_EXPORT {
                                    ^~~~~~~~~~~~~~~~
CommonAPI-3.2/CommonAPI/Export.hpp:19:46: note: expanded from macro 'COMMONAPI_EXPORT'
    #define COMMONAPI_EXPORT __attribute__ ((visibility ("default")))
                                             ^~~~~~~~~~~~~~~~~~~~~~

Closes: #25

The structure is declared in the header and the export is unused as seen
with clang and -Wignored-attributes:

CommonAPI-3.2/CommonAPI/Logger.hpp:31:37: warning: 'visibility' attribute ignored when parsing type [-Wignored-attributes]
    enum class Level : std::uint8_t COMMONAPI_EXPORT {
                                    ^~~~~~~~~~~~~~~~
CommonAPI-3.2/CommonAPI/Export.hpp:19:46: note: expanded from macro 'COMMONAPI_EXPORT'
    #define COMMONAPI_EXPORT __attribute__ ((visibility ("default")))
                                             ^~~~~~~~~~~~~~~~~~~~~~

Closes: COVESA#25

Signed-off-by: Gustavo Sverzut Barbieri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation problem: error: 'visibility' attribute ignored when parsing type (enum)
1 participant